Add support for broadcasting Ruuvi Sensor Data service UUID (and any other service UUID) #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewpad Report
|
ojousima
requested review from
TheSomeMan
and removed request for
markoaamunkajo
|
@TheSomeMan This PR adds a firmware variant that advertises Ruuvi service UUID. To fit the UUID in, a new shorter data format C5 is added, and drivers have been extended to support UUID advertising. Especially src/app_dataformats.c data format cycling logic should be checked together with src/app_heartbeat.c enabled data format definition. |
TheSomeMan
approved these changes
Jan 31, 2024
src/app_dataformats.c
Outdated
| return DF_5; | ||
| app_dataformat_t nextState = DF_INVALID; | ||
|
|
||
| if (formats.formats) |
There was a problem hiding this comment.
Suggestion from SonarCloud: Explicitly test this expression against zero.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help some phones on their background scan.